Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources for extensions are still downloaded with --module-only #3849

Closed
ocaisa opened this issue Sep 24, 2021 · 2 comments · Fixed by #3860
Closed

Sources for extensions are still downloaded with --module-only #3849

ocaisa opened this issue Sep 24, 2021 · 2 comments · Fixed by #3860
Labels
bug report
Milestone
4.5.0

Comments

@ocaisa
Copy link
Member

ocaisa commented Sep 24, 2021

I was testing --module-only with the EESSI stack to build my module tree and my VM ran out of space. I thought it was the CVMFS cache (which was indeed partially to blame) but actually it turned out that the /tmp was full and inside I found a sources directory that was populated with lots of extension sources.
@boegel boegel added this to the next release (4.5.0?) milestone Sep 29, 2021
@boegel
Copy link
Member

boegel commented Sep 29, 2021

This happens because init_ext_instances which is triggered via _sanity_check_step_extensions calls fetch_extension_sources in the EasyBlock class (since #3655).

We need those extension instances for the sanity check, but we don't actually need the sources, so we should decouple creating extension instances and downloading sources (so breaking up fetch_extension_sources, which now does both).

@boegel boegel mentioned this issue Oct 14, 2021
Merged
14 tasks
boegel added a commit to boegel/easybuild-framework that referenced this issue Oct 16, 2021
@boegel
tweak test_module_only_extensions to catch bug reported in easybuilde…
988e813 
…rs#3849
boegel added a commit to boegel/easybuild-framework that referenced this issue Oct 16, 2021
@boegel
refactor EasyBlock to decouple collecting of information on extension…
6a86fc0 
… source/patch files from downloading them (fixes easybuilders#3849)

includes deprecating EasyBlock.fetch_extension_sources and replacing it with EasyBlock.collect_exts_file_info
boegel added a commit to boegel/easybuild-framework that referenced this issue Oct 16, 2021
@boegel
refactor EasyBlock to decouple collecting of information on extension…
ea21234 
… source/patch files from downloading them (fixes easybuilders#3849)

includes deprecating EasyBlock.fetch_extension_sources and replacing it with EasyBlock.collect_exts_file_info
boegel added a commit to boegel/easybuild-framework that referenced this issue Oct 16, 2021
@boegel
refactor EasyBlock to decouple collecting of information on extension…
ecb2221 
… source/patch files from downloading them (fixes easybuilders#3849)

includes deprecating EasyBlock.fetch_extension_sources and replacing it with EasyBlock.collect_exts_file_info
boegel added a commit to boegel/easybuild-framework that referenced this issue Oct 16, 2021
@boegel
refactor EasyBlock to decouple collecting of information on extension…
b7edf1d 
… source/patch files from downloading them (fixes easybuilders#3849)

includes deprecating EasyBlock.fetch_extension_sources and replacing it with EasyBlock.collect_exts_file_info
@boegel boegel mentioned this issue Oct 16, 2021
Merged
@boegel
Copy link
Member

boegel commented Oct 16, 2021

Semi-large refactoring done in #3860 which fixes this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
4.5.0
2 participants
@boegel @ocaisa