86 encoding scheme #106
86 encoding scheme #106
Conversation
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
…ng(name) Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
…), name)) Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
correct naming of classes for Python packages nose, numpy and scipy
| from easybuild.tools.module_generator import ModuleGenerator | ||
| from easybuild.tools.modules import Modules, get_software_root | ||
| from easybuild.tools.toolkit import Toolkit | ||
| from easybuild.tools.systemtools import get_core_count | ||
|
|
||
|
|
||
| EBCLASSPREFIX = 'eb_' |
There was a problem hiding this comment.
With the prefixing, and certainly with the encoding of class names, wer'e violating (http://www.python.org/dev/peps/pep-0008/#class-names)[the PEP008 class naming rule].
But, since we have a good technical reason for that, that's OK (we just need to document our motivation).
However, I think I prefer the change the prefix to EB_ (I don't think we discussed upper vs lowercase prefixes?).
Having class names start with a capital letter makes more sense to me.
Your thoughts?
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
|
|
||
| def encode_string(name): | ||
| """ | ||
|
|
There was a problem hiding this comment.
get rid of this empty line, it might screw up the generated documentation
Signed-off-by: Fotis Georgatos <fotis.georgatos@uni.lu>
|
Thanks for fixing all my remarks, and congratulations on your first contribution to EasyBuild! |
|
documentation draft: https://github.com/fgeorgatos/easybuild.experimental/wiki/Encode-class-names |
Hi,
see issue #86 in relation to this pull request.
sorry for the single pull request for all 6 commits; I still have to learn some git ropes to refactor the commits...
I will be carefully checking the remarks on github though... be strict to make the first shot just right.
cheers,
Fotis