Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 'git am' to apply patch for PRs in fetch_easyconfigs_from_pr #2680

Merged
merged 2 commits into from
Dec 6, 2018
Merged

use 'git am' to apply patch for PRs in fetch_easyconfigs_from_pr #2680

merged 2 commits into from
Dec 6, 2018

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 5, 2018

fix + test for #2679

@boegel boegel added the bug fix label Dec 5, 2018
@boegel boegel added this to the 3.8.0 milestone Dec 5, 2018
@boegel boegel mentioned this pull request Dec 5, 2018
Merged
migueldiascosta
migueldiascosta approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit 1d1b731 into easybuilders:develop Dec 6, 2018
@migueldiascosta migueldiascosta mentioned this pull request Dec 6, 2018
Closed
@boegel boegel deleted the fix_from_pr_renamed_files branch December 6, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @migueldiascosta