also support %(installdir)s and %(builddir)s templates for extensions #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akesandgren
changed the title
|
This solves my problem of using %(installdir)s in a preinstallopts in an exts_list in GROMACS |
boegel
requested changes
Mar 9, 2020
There was a problem hiding this comment.
@akesandgren lgtm, but needs to be covered in the tests too...
easybuild/framework/extension.py
Outdated
| @@ -111,6 +111,11 @@ def __init__(self, mself, ext, extra_params=None): | |||
| # construct dict with template values that can be used | |||
| self.cfg.template_values.update(template_constant_dict({'name': name, 'version': version})) | |||
|
|
|||
| # Add install/builddir templates, copied from update_config_template_run_step | |||
| # do we need to call self.cfg.generate_template_values() after? | |||
There was a problem hiding this comment.
No need to call generate_template_values, so you can drop this comment.
There was a problem hiding this comment.
I thought so, since that's already done in master.
Clarify where the values for install/builddir is coming from.
|
BTW, this is going to be vital for GROMACS 2020.1 with the gmxapi extension. |
This was referenced Mar 9, 2020
Closed
akesandgren
changed the title
boegel
approved these changes
Mar 11, 2020
boegel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.