Introduce contextmanager for disabling templating and reduce resolving errors #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
less_templating
branch
from
7ad6faf to
91c7f0d
Compare
smoors
changed the title
boegel
reviewed
May 1, 2020
| if key in self.cfg: | ||
| self.cfg[key] = resolve_template(self.options[key], self.cfg.template_values) |
There was a problem hiding this comment.
This was a bit silly indeed, since templates in self.options are already resolved above... Nice catch!
|
Going in, thanks @Flamefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context manager is a better alternative to the currently widely used pattern of
Advantage: Shorter and safer as the reset cannot be forgotten even in case of exceptions
Afterwards some template resolving failures are removed which are observed in #3285
Diff looks larger than it is as indentation has changed and Github seems to be bad in handling this. All changes are trivial.