Constants for osdependecies.

[terjekv]

• The osdependencies relating to ibverbs and openssl are repeated
  ad nauseam in the code. Occasionally with minor mistakes added
  in.
• ibverbs / infiniband and openssl are the most frequent
  package lists used, but their use is inconsistent as
  packages change name over time.
• When packages change names, old easyconfigs will stop working
  unless the dependency statement is updated.
• Moving these lists into constants allows for the lists to be
  updated in one place and at one time.

[terjekv]

Usage: osdependencies = [OS_PKG_IBVERBS_DEV]. For perl, one can change osdependencies = ['openssl', ('openssl-devel', 'libssl-dev', 'libopenssl-devel')] into osdependencies = [OS_PKG_OPENSSL_BIN, OS_PKG_OPENSSL_DEV].

[terjekv]

@boegel :-(

Found printed messages in output of test suite\nERROR: test_easyconfig_constants (test.framework.easyconfigparser.EasyConfigParserTest) File "/tmp/681175494/lib/python2.7/site-packages/easybuild_framework-4.2.1.dev0-py2.7.egg/test/framework/easyconfigparser.py", line 187, in test_easyconfig_constants self.assertTrue(isinstance(val, (string_type, dict)), "Constant value %s is a string or dict" % val)

Does this mean that constants can't be lists? If so, either the test needs to be changed, or I'll have to wrap the list in a dict and then unpack at a later stage, but that just seems like circumventing the intent of the test.

[boegel]

@terjekv Using a list type value ([1,2,3]) as a constant is a bad idea because lists are mutable, but using a tuple ((1,2,3)) should be fine (and thus changing that check to also accept tuples as constant values is OK).

[terjekv]

@terjekv Using a list type value ([1,2,3]) as a constant is a bad idea because lists are mutable, but using a tuple ((1,2,3)) should be fine (and thus changing that check to also accept tuples as constant values is OK).

Blargh. I fail at terminology. Sorry about that. I ment tuple. I have updated the test code. Let's see if that helps.

[boegel]

Thanks a lot @terjekv!