Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always take into account builddependencies when generating template values, also when we're not iterating over builddependencies #3346

Merged
merged 12 commits into from
Jul 3, 2020
Merged

always take into account builddependencies when generating template values, also when we're not iterating over builddependencies #3346

merged 12 commits into from
Jul 3, 2020

Conversation

ekouts
Copy link
Contributor

@ekouts ekouts commented May 25, 2020 •
edited by boegel
Loading

fixes #3300, fixes #2114

@boegel boegel added this to the next release (4.2.2?) milestone Jun 24, 2020
@easybuilders easybuilders deleted a comment from boegelbot Jun 24, 2020
@easybuilders easybuilders deleted a comment from boegelbot Jun 24, 2020
@easybuilders easybuilders deleted a comment from boegelbot Jun 24, 2020
@boegel
also consider builddependencies when config passed to template_consta…
36c95a4 
…nt_dict is not an EasyConfig instance yet + add comments to clarify what's going on
@boegel boegel mentioned this pull request Jul 3, 2020
Merged
@ekouts
Merge pull request #1 from boegel/template_builddependencies
d5945bb 
also consider builddependencies when config passed to template_constant_dict is not an EasyConfig instance yet + add comments to clarify what's going on
ekouts and others added 2 commits July 3, 2020 18:03
@ekouts @boegel
Update easybuild/framework/easyconfig/templates.py
c2bb403 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@ekouts @boegel
Update easybuild/framework/easyconfig/templates.py
2235efb 
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
@hound hound bot deleted a comment from boegel Jul 3, 2020
@easybuilders easybuilders deleted a comment from boegelbot Jul 3, 2020
boegel
boegel previously approved these changes Jul 3, 2020
View reviewed changes
@boegel boegel force-pushed the template_builddependencies branch from d3d0149 to 44b03c5 Compare July 3, 2020 19:11
@boegel boegel mentioned this pull request Jul 3, 2020
Closed
@boegel boegel changed the title Take into account builddependencies in software templates always take into account builddependencies when generating template values, also when we're not iteraring over builddependencies Jul 3, 2020
@boegel boegel merged commit eedcfc8 into easybuilders:develop Jul 3, 2020
@boegel boegel changed the title always take into account builddependencies when generating template values, also when we're not iteraring over builddependencies always take into account builddependencies when generating template values, also when we're not iterating over builddependencies Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix change
Projects
None yet
Milestone
4.2.2
2 participants
@ekouts @boegel