Allow amending easyconfig parameters which are not the default #3651
Conversation
Overwriting parameters which are not in the EC and not one of a few standard ones is currently impossible. However it is useful when e.g. EasyBlocks introduce new params where the user wants to overwrite the default value without changing the EC manually. This change allows this by simply appending the new parameter when it is not in the default list.
Flamefire
force-pushed
the
overwriteNonDefaultECParams
branch
from
a5f5a04 to
befebc3
Compare
We already have this case covered by the variable naming enforcement, i.e. loading an EC with an unknown parameter not named local_* will already error out
boegel
changed the title
| specs.update({ | ||
| 'foo': 'bar123' | ||
| }) | ||
| self.assertErrorRegex(EasyBuildError, "Unknown easyconfig parameter: foo", |
There was a problem hiding this comment.
I would think this test is still useful for parameters that are not defined in the easyblock, or is that taken care of somewhere else?
There was a problem hiding this comment.
That is taken care of elsewhere. I don't think we can trigger this error anymore at all, as that is specific to using non-default parameters which we allow now.
The EasyBlock instantiation will trigger e.g. "Use of 2 unknown easyconfig parameters detected in test.eb: foo, some_list", see test_fix_deprecated_easyconfigs
Co-authored-by: Sam Moors <smoors@users.noreply.github.com>
|
@smoors Took your suggestion but had to add an is-string check or it will fail for unhashable types (e.g. other dicts) as values. I also reordered the dict and interspersed the comments which IMO is easier to understand. Check if you agree please. |
|
Going in, thanks @Flamefire! |
Overwriting parameters which are not in the EC and not one of a few standard ones is currently impossible.
However it is useful when e.g. EasyBlocks introduce new params where the user wants to overwrite the default value without changing the EC manually.
This change allows this by simply appending the new parameter when it is not in the default list.