Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move disable_templating function into the EasyConfig class #3668

Merged
merged 1 commit into from
May 12, 2021

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Apr 28, 2021

Allows easier use from outside as e.g. a few tests and easyblocks use it
The free function now just redirects to the member function

This also changes all uses if ec.enable_templating = False to use the context manager which avoids "forgetting" to reset it on error

Allows easier use from outside as e.g. a few tests and easyblocks use it
The free function now just redirects to the member function
@Flamefire Flamefire force-pushed the move_disable_templating branch from 7d85ed1 to 4c3cd39 Compare April 28, 2021 14:34
@boegel boegel changed the title Move disable_templating into the EC class move disable_templating function into the EasyConfig class May 12, 2021
@boegel boegel added this to the next release (4.3.5?) milestone May 12, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants