New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code style issues reported by recent flake8 linter #4049

Merged

boegel merged 1 commit into easybuilders:develop from Flamefire:linter

Aug 3, 2022

Contributor

Flamefire commented Aug 2, 2022

Recent flake8 complains about a missing space after keywords:

C-style while(condition) instead of while condition:
not(condition) (actually better: return self.version is not None and self.operator is not None, but that's personal preference)
Rewrote the if-condition checking for stream attr to remove the or
Missing error class in raise. Settled on ValueError as the hdlr has a missing or invalid stream value


          Fix linting issues

7d63e0c

boegel added bug fix code cleanup tests labels

boegel added this to the next release (4.6.1?) milestone

boegel approved these changes

View reviewed changes

Member

boegel left a comment

lgtm

boegel changed the title ~~Fix linting issues~~ fix code style issues reported by recent flake8 linter

boegel merged commit c10f1e0 into easybuilders:develop

Flamefire deleted the linter branch

August 3, 2022 09:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix code cleanup tests