Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --check-github as gist url now includes username #4231

Merged
merged 3 commits into from
Mar 29, 2023
Merged

fix --check-github as gist url now includes username #4231

merged 3 commits into from
Mar 29, 2023

Conversation

branfosj
Copy link
Member

fixes #4230

@branfosj branfosj added this to the next release (4.7.2?) milestone Mar 28, 2023
Micket
Micket previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Mar 28, 2023 •
edited
Loading

Should mock testing be adjusted as well maybe?

easybuild-framework/test/framework/github.py

Line 1133 in 5b420bb

r"^See https://gist.github.com/DRY_RUN for a full test report.'",

(along with the dry run output?)

easybuild-framework/easybuild/tools/github.py

Line 592 in 5b420bb

status, data = HTTP_STATUS_CREATED, {'html_url': 'https://gist.github.com/DRY_RUN'}

boegel
boegel requested changes Mar 29, 2023
View reviewed changes
easybuild/tools/github.py Outdated Show resolved Hide resolved
test/framework/github.py Outdated Show resolved Hide resolved
boegel
boegel approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel enabled auto-merge March 29, 2023 18:28
@boegel boegel merged commit b73b32d into easybuilders:develop Mar 29, 2023
@branfosj branfosj deleted the gist branch March 30, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

@Micket Micket Micket left review comments

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.

GitHub integration check falsely reports gist creation issues
3 participants
@branfosj @Micket @boegel