Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail in mkdir if path gets created while processing it #4300

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

Flamefire
Copy link
Contributor

This may happen if a parallel build creates e.g. the sources-directory

Reported in Slack

I'm now seeing this error when I try to run a CI job (which runs EB to test installing some software)

HASH=$(git rev-parse HEAD) eb ci-plans/files/ligka_ci_actor.eb -f ${EB_OPTS} ${EB_HTTP_OPTS}
ERROR: Build of /home/ITER/haywart/src/ligka/ci-plans/files/ligka_ci_actor.eb failed (err: "build failed (first 300 chars): Failed to create directory /home/ITER/haywart/src/ligka/sources/generic/eb_v4.8.0/ConfigureMake: [Errno 17] File exists: '/home/ITER/haywart/src/ligka/sources/generic/eb_v4.8.0/ConfigureMake'")

Note that our mkdir is documented referring to mkdir -p which also doesn't fail if the directory exists.

This may happen if a parallel build creates e.g. the sources-directory
Co-authored-by: ocaisa <alan.ocais@cecam.org>
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I don't see how we can (with reasonable effort) add a test for this, so if this fixes the issue you saw I'm happy to include it.

@ocaisa ocaisa merged commit 4329c3a into easybuilders:develop Jul 24, 2023
@Flamefire Flamefire deleted the fix-mkdir branch July 24, 2023 08:54
@boegel boegel added the bug fix label Aug 2, 2023
@boegel boegel added this to the next release (4.8.1?) milestone Aug 2, 2023
@boegel boegel changed the title Don't fail mkdir if path gets created while processing it don't fail mkdir if path gets created while processing it Aug 2, 2023
@boegel boegel changed the title don't fail mkdir if path gets created while processing it don't fail in mkdir if path gets created while processing it Aug 2, 2023
@Flamefire
Copy link
Contributor Author

Ouch, I missed that FileExistsError is a Python 3 thing and doesn't exist in Python2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants