Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more recent easyblocks PR in test_github_merge_pr #4414

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 26, 2023

fix for broken test because commit status is no longer available (so test suite passes fails with status: None):

FAIL: test_github_merge_pr (__main__.CommandLineOptionsTest)
Test use of --merge-pr (dry run)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/work/easybuild-framework/easybuild/base/testing.py", line 97, in assertEqual
    super(TestCase, self).assertEqual(a, b)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 831, in assertEqual
    assertion_func(first, second, msg=msg)
AssertionError: '* test suite passes: (status: None) => no[110 chars]way)' != ''
- * test suite passes: (status: None) => not eligible for merging!
-
- WARNING: Review indicates this PR should not be merged (use -f/--force to do so anyway)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Volumes/work/easybuild-framework/test/framework/options.py", line 4831, in test_github_merge_pr
    self.assertEqual(stderr.strip(), '')
  File "/Volumes/work/easybuild-framework/easybuild/base/testing.py", line 119, in assertEqual
    raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF])))
AssertionError: '* test suite passes: (status: None) => no[110 chars]way)' != ''
- * test suite passes: (status: None) => not eligible for merging!
-
- WARNING: Review indicates this PR should not be merged (use -f/--force to do so anyway):
DIFF:
- * test suite passes: (status: None) => not eligible for merging!
-

@boegel boegel added the bug fix label Dec 26, 2023
@boegel boegel added this to the next release (4.9.0) milestone Dec 26, 2023
Copy link
Contributor

@zao zao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zao zao enabled auto-merge December 26, 2023 15:54
@boegel boegel changed the title use more recent easyblocks PR in test_github_merge_pr use more recent easyblocks PR in test_github_merge_pr Dec 26, 2023
@boegel boegel added the tests label Dec 26, 2023
@zao zao merged commit 24d7862 into easybuilders:develop Dec 26, 2023
40 checks passed
@boegel boegel deleted the fix_test_github_merge_pr branch December 26, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants