also run unit tests with Python 3.12 + add it to classifiers in setup.py
#4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This (or "pip install build" with "python -m build") is needed for Python 3.12 with "python setup.py sdist"
|
I didn't add setuptools to requirements.txt since it's not an explicit runtime dependency, we only need it for |
This gives a SyntaxWarning in Python 3.12. In older Pythons it would not warn, but in all cases it gives a literal raw \u (with a backslash) instead of Unicode characters. Python 2.x needed u'\uxxxx' but the u is no longer needed with 3.x.
|
Still needs some work on Unicode handling. |
This fixes Python 3.6 with LC_ALL=C. For Python 3.7+ we always get 'utf-8': https://docs.python.org/3/library/os.html#utf8-mode
boegel
requested changes
Mar 15, 2024
.github/workflows/unit_tests.yml
Outdated
| @@ -83,6 +85,10 @@ jobs: | |||
| pip install --upgrade pip | |||
| pip --version | |||
| pip install -r requirements.txt | |||
| if [[ "${{matrix.python}}" == 3.12 ]]; then | |||
There was a problem hiding this comment.
This will also be required for Python versions > 3.12, right?
Can we cut off the minor part (12) and then do a comparison, so we can forget about this?
There was a problem hiding this comment.
I thought in the end it's even better to check for functionality: so checking if distutils can be imported rather than an explicit version check.
This makes the check more general and compatible with later versions of Python than just 3.12.
boegel
approved these changes
Mar 24, 2024
This was referenced Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.