-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't raise error when required extensions are not found when installing extensions in parallel #4671
don't raise error when required extensions are not found when installing extensions in parallel #4671
Conversation
…ing extensions in parallel
Hmm, this is not enough, since eventually things will get stuck because no new extensions are being picked up anymore, need to check why that's happening:
|
… assumed to be provided by dependencies in install_extensions_parallel
a879eb9
to
1d31c21
Compare
…g list of pending required extensions
This seems to be working well now with
There's no The issue is that the Always using |
Extensive test report coming up with |
Extensive test report for bundles of R packages on top of this is available at easybuilders/easybuild-easyblocks#3490 (comment), which shows this is good to go... |
Raising an error effectively makes it impossible to use
--parallel-extensions-install
on bundle easyconfigs likeR-bundle-CRAN-2024.06-foss-2023b.eb
andR-bundle-Bioconductor-3.18-foss-2023a-R-4.3.2.eb
.There's actually no reason to give up when extensions that are required dependencies for an extension that will be installed are not included in
exts_list
, since they're probably provided via a dependency likeR
orR-bundle-CRAN
.Note that this is exactly what we do currently when installing extensions sequentially...
If a dependency of a particular extension is totally missing, the installation of that extension will fail as it does when installing sequentially.
Note: for using
--parallel-extensions-install
onR-bundle-CRAN
(or olderR
easyconfigs that includeRmpi
andRserve
), an additional bug fix is required, see:return
for customisedinstall_extension_async
methods in Rserve and Rmpi easyblocks easybuild-easyblocks#3474