Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change semantics of --dry-run, so it doesn't imply --robot #4704

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

smoors
Copy link
Contributor

@smoors smoors commented Nov 12, 2024

--dry-run without --robot should only show info about the easyconfig itself, not the dependencies.

@smoors smoors added the EasyBuild-5.0 EasyBuild 5.0 label Nov 12, 2024
@smoors smoors mentioned this pull request Nov 12, 2024
@smoors smoors added the bug fix label Nov 12, 2024
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm i guess, have we discussed this change?

@Micket Micket added this to the 5.0 milestone Nov 15, 2024
@boegel
Copy link
Member

boegel commented Nov 16, 2024

Hmm, muscle memory is strong for me for using -D and getting full overview of what's needed, but typing an extra r isn't too bad, so I don't mind.

I guess we should check with maintainers if anyone else strongly objects, but I can live with it.

@smoors I do wonder what motivated you to look into this...

@boegel boegel added change and removed bug fix labels Nov 16, 2024
@boegel boegel changed the title fix --dry-run without --robot change semantics of --dry-run, so it doesn't imply --robot Nov 16, 2024
@smoors
Copy link
Contributor Author

smoors commented Nov 17, 2024

consistency! :)

this is useful when working with an easystack file, and you want to check for each easyconfig in the easystack if it has been installed and get the corresponding module name. you can of course do a grep on the output, but it’s a bit cumbersome.

@smoors smoors requested a review from lexming November 19, 2024 11:01
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Micket
Copy link
Contributor

Micket commented Nov 22, 2024

Everyone is on board. Merging

@Micket Micket merged commit 34466de into easybuilders:5.0.x Nov 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants