Potentially breaking change: Throw PersistenceException for unknown property in select clause #3499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty in select clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior behaviour was "relaxed" / "loose" in that it allowed unknown properties in the select clause to be ignored.
At this stage, I think this was likely to be bad behaviour in that it might not be expected and people might be thinking that the select clause is successfully including a property that in fact was getting ignored.
If you have an application that hits this
PersistenceException("Property not found - ___")exception and you don't like this change in behaviour, please get in touch and lets see. In theory this change should make the behaviour better but there might be code out there that is based on the assumption that the select clause is "relaxed" wrt unknown properties.