Skip to content

Commit

Permalink
Cleanup and fix for issue related to perms when running create_release
Browse files Browse the repository at this point in the history
  • Loading branch information
ebridges committed Feb 7, 2024
1 parent 5370c3d commit dc02d04
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/maven-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Maven Package
on:
push:
tags:
- 'v[0-9][0-9]?.[0-9][0-9]?'
- 'v[0-9][0-9]?.[0-9][0-9]?.[0-9][0-9]?'

jobs:
build:
Expand All @@ -19,13 +19,13 @@ jobs:
with:
java-version: '17'
distribution: 'temurin'
server-id: github # Value of the distributionManagement/repository/id field of the pom.xml
server-id: github
settings-path: ${{ github.workspace }}
cache: maven

- name: Generate changelog
id: changelog
uses: mikepenz/release-changelog-builder-action@v2
uses: mikepenz/release-changelog-builder-action@v4
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand All @@ -42,15 +42,16 @@ jobs:

- name: Create release
id: create_release
if: github.event_name == 'push'
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # This token is provided by Actions, you do not need to create your own token
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
tag_name: ${{ github.ref }}
release_name: Release ${{ github.ref }}
body: |
Changes in this Release
- ${{ steps.changelog.outputs.changelog }} # This will contain the changelog generated by the next step
- ${{ steps.changelog.outputs.changelog }}
- name: Build with Maven
run: mvn -B package --file pom.xml --settings $GITHUB_WORKSPACE/settings.xml
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ The following environment variables can be configured for the application:

## Releasing

Tag the `master` branch with a tag of the form `vX.Y` where X & Y are integers from 0-99. This will create a Github release and publish a standalone executable JAR file to the Github packages repository.
Tag the `master` branch with a tag of the form `vX.Y.Z` where X, Y, & Z are integers from 0-99. This will create a Github release and publish a standalone executable JAR file to the Github packages repository.

## Running

Expand Down

0 comments on commit dc02d04

Please sign in to comment.