Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon revert get active account #3062

Merged
merged 10 commits into from
Oct 16, 2024
Merged

Conversation

hui-an-yang
Copy link
Collaborator

@hui-an-yang hui-an-yang commented Oct 7, 2024

[breaking change] removing public property account on class BeaconWallet
@taquito/beacon-wallet - revert the use of subscribe to ACTIVE_ACCOUNT_SET in the package to ensure users will get a warning in the console if they didn't subscribe themselves.
@taquito/beacon-wallet - added broadcast-channel mock for @airgap/beacon-transport-postmessage in unit test
internal dependencies update closes #3039 #3059 #3060 #3061 #3063

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

github-actions bot commented Oct 7, 2024

A new deploy preview is available on Cloudflare Pages at https://c3823294.taquito-test-dapp.pages.dev

Copy link

cloudflare-workers-and-pages bot commented Oct 7, 2024

Deploying taquito with  Cloudflare Pages  Cloudflare Pages

Latest commit: 47944c7
Status: ✅  Deploy successful!
Preview URL: https://ae1de67f.taquito.pages.dev
Branch Preview URL: https://beacon-revert-getactiveaccou.taquito.pages.dev

View logs

Copy link

github-actions bot commented Oct 7, 2024

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/rpc@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/taquito@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/timelock@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/core@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@20.1.0-06c8356-- --registry https://npm.preview.tezostaquito.io/

@hui-an-yang hui-an-yang marked this pull request as ready for review October 10, 2024 00:54
Copy link
Collaborator

@roxaneletourneau roxaneletourneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but see the note about breaking change.

@hui-an-yang hui-an-yang added this to the v20.1 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants