Quebec #3068
Open
Quebec #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider for user query old block BREAKING CHANGE: PollingSubscribeProvider doesn't filter endorsement anymore and removed rpc entrypoints using param version 0 re #3036
…oved type PendingOperationsV1 BREAKING CHANGE: PendingOperationsQueryArguments.version used to accept 1 is removed for protocol q re #3034
|
A new deploy preview is available on Cloudflare Pages at https://508bd2e6.taquito-test-dapp.pages.dev |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
Deploying taquito with
|
| Latest commit: |
9e6ff6e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10991cfa.taquito.pages.dev |
| Branch Preview URL: | https://quebec.taquito.pages.dev |
github-actions
bot
requested a deployment
to
taquito-test-dapp (Preview)
…onfig for beta release
| env: | ||
| # Ternary operator workaround | ||
| TEZOS_RPC_${{ matrix.testnet_uppercase }}: ${{ github.event.pull_request.head.repo.fork && format('https://{0}.ecadinfra.com', matrix.testnet) || null }} | ||
| TEZOS_RPC_${{ matrix.testnet_uppercase }}: ${{ github.event.pull_request.head.repo.fork && matrix.rpc_url || null }} | ||
| # integration-tests-quebec-secret-key: |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
I only use secret key script to develop when there is no keygen support yet in a new protocol, find it handy to have the script around but not necessary. I don't mind removing it if it's cleaner :)
There was a problem hiding this comment.
I feel it cleaner to remove it, and we can always find it in the git history, but it is up to you :)
| @@ -8,120 +8,122 @@ author: Roxane Letourneau | |||
| 1. The RPC nodes' integration tests are disabled by default. | |||
| Remove `./rpc-nodes.spec.ts` from `"testPathIgnorePatterns"` in the package.json. | |||
|
|
|||
| **parisnet**: `npm run test:parisnet rpc-nodes.spec.ts` | |||
| **parisnet**: `npm run test:quebecnet-secret-key integration-tests/__tests__/rpc/nodes.spec.ts` | |||
There was a problem hiding this comment.
Should parisnet be replaced with quebecnet?
There was a problem hiding this comment.
yes will update this, thank you!
| @@ -2385,14 +2388,15 @@ export type LastRemovedCommitmentHashes = { | |||
| }; | |||
|
|
|||
| export interface PendingOperationsQueryArguments { | |||
| version?: '1' | '2'; | |||
There was a problem hiding this comment.
Should we keep '1' to stay compatible with precedent protocol?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.