CampProgram: fix create activity #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
requested review from
carlobeltrame,
pmattmann,
manuelmeister and
usu
4 tasks
BacLuc
changed the title
manuelmeister
approved these changes
Nov 10, 2021
carlobeltrame
requested changes
Nov 11, 2021
api/src/Entity/Activity.php
Outdated
| #[ApiProperty(writable: false, example: '["/schedule_entries/1a2b3c4d"]')] | ||
| #[Groups(['read'])] | ||
| #[Assert\Valid] | ||
| #[ApiProperty(writableLink: true, example: '["/schedule_entries/1a2b3c4d"]')] |
There was a problem hiding this comment.
Das Example für OpenAPI solltest du noch anpassen, siehe Camp->$periods. Nur die required Felder würden mir reichen, sodass man einen Startpunkt zum Copy Pasten hat in Swagger.
| */ | ||
| #[ApiProperty(writable: false, example: '["/schedule_entries/1a2b3c4d"]')] | ||
| #[Groups(['read'])] | ||
| #[Assert\Valid] |
There was a problem hiding this comment.
Beim Camp habe ich noch eine Validierung #[Assert\Count(min: 1, groups: ['create'])], wäre hier wohl auch sinnvoll oder? Vorschlag von Forte war ja mal, beim Löschen des letzten ScheduleEntries wird auch die Activity gelöscht.
With the changes made with api platform. Also use period iri instead of id to filter activies in Picasso.vue. Remove periodId from the payload and send period iri in DialogActivityCreate.vue. Use category iri to reference the category in DialogActivityForm.vue. Use cascade persist in the Activity Entity to persist created ScheduleEntries. Checked with docker-compose exec php bin/console doctrine:migrations:diff that no migration is necessary. ScheduleEntry already has onDelete=cascade on the joincolumn. Use $this->activity?->getCamp() instead of property access in ScheduleEntry because when an activity is created, the camp is null (this is attached in the persister), and Activity::getCamp returns the camp of the category. Issue: ecamp#2029
Don't append "Id" to embedded entities Use _meta.self as value instead of the object. DialogBase for an edit dialog with embedded Entity is only used in DialogActivityEdit.vue. Relates to ecamp#2198 Issue: ecamp#2029
Patch of an embedded collection did not work. Relates to ecamp#2195 Issue: ecamp#2029
BacLuc
force-pushed
the
campprogram-fix-create-activity
branch
from
f9daa38
to
d3a5d58
Compare
carlobeltrame
approved these changes
Nov 15, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unschönheiten:
Fehler: