deploy to production #3719
Merged
deploy to production #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a separate network request for each day)
We want to use the swiss specific locale for the moment. If we someday want to allow other values, then I would suggest making this a setting in the profile.
chore: add filter to query for all dayResponsibles of a period
Co-authored-by: Bacluc <lucius.bachmann@gmx.ch>
french translations
After fixing the psalm errors and an update of phpstan,
we have now phpstan errors.
This fixes the following errors:
------ ---------------------------------------------------------------------------------------------------------------------------------------------------
Line State/ContentNode/ContentNodePersistProcessor.php
------ ---------------------------------------------------------------------------------------------------------------------------------------------------
24 Access to an undefined property App\Entity\BaseEntity::$parent.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
25 Access to an undefined property App\Entity\BaseEntity::$parent.
💡 Learn more: https://phpstan.org/blog/solving-phpstan-access-to-undefined-property
28 Method App\State\ContentNode\ContentNodePersistProcessor::onBefore() should return T of App\Entity\ContentNode but returns App\Entity\BaseEntity.
------ ---------------------------------------------------------------------------------------------------------------------------------------------------
------ -------------------------------------------------------------------------------------
Line State/Util/AbstractPersistProcessor.php
------ -------------------------------------------------------------------------------------
72 PHPDoc tag @return with type T is not subtype of native type App\Entity\BaseEntity.
💡 Write @template T of App\Entity\BaseEntity to fix this.
------ -------------------------------------------------------------------------------------
fix ApiPlatform deprecations
Instead of deprecated Symfony\Component\Security\Core\Security.
We never want to delete the data in prod. And if we want to, we can copy the code from the dev-data directory.
…of getNormalizerCollection Psalm and phpstan don't aggree on the type, psalm is a little stricter and considers the number of elements in the collection. /** * @phpstan-return ArrayCollection<int, AbstractConstraintViolationListNormalizer> * * @psalm-return ArrayCollection<int<0, 1>, AbstractConstraintViolationListNormalizer> */ I would say it leads to less maintenance if we remove the type, and both phpstan and psalm can infer the type.
* e2e: run lint and add check Use shared .prettierrc from root. docker compose run --rm --entrypoint="npm run lint" e2e Remove eslintrc conflicting with the eslint config in package.json. Add check in CI. * e2e: add commands for dependency management to README.md * e2e: separate xhost setup and start in README.md That you can run the README shell snippet 'xhost local:root' directly from the IDE. * e2e: add eslint-plugin-cypress
TranslationConstraintViolationListNormalizer: remove type annotation …
Persist dashboard filters in query params
fix e2e-prettier
pmattmann
approved these changes
Aug 16, 2023
usu
approved these changes
Aug 16, 2023
BacLuc
approved these changes
Aug 16, 2023
manuelmeister
approved these changes
Aug 17, 2023
|
/fast-forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.