Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add red asterisk to required selects #3994

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add red asterisk to required selects #3994

merged 1 commit into from
Oct 21, 2023

Conversation

carlobeltrame
Copy link
Member

Before:
Screenshot 2023-10-21 at 15-10-14 eCamp3

After:
Screenshot 2023-10-21 at 15-10-30 eCamp3

Copied the SCSS from ETextField.vue

manuelmeister
manuelmeister approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimally required should have a screen reader text. This is only a visual fix

@carlobeltrame carlobeltrame added this pull request to the merge queue Oct 21, 2023
@carlobeltrame carlobeltrame removed this pull request from the merge queue due to a manual request Oct 21, 2023
@carlobeltrame carlobeltrame mentioned this pull request Oct 21, 2023
Open
@carlobeltrame carlobeltrame added this pull request to the merge queue Oct 21, 2023
Merged via the queue into ecamp:devel with commit dee5b3a Oct 21, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmeister manuelmeister manuelmeister approved these changes

@BacLuc BacLuc BacLuc approved these changes

@pmattmann pmattmann pmattmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlobeltrame @pmattmann @BacLuc @manuelmeister