-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency sentry/sentry-symfony to v5 #4901
Conversation
dc5ff67
to
e03625f
Compare
e03625f
to
6d90935
Compare
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -3,8 +3,9 @@ sentry: | |||
register_error_listener: false # Disables the ErrorListener to avoid duplicated log in sentry | |||
options: | |||
environment: '%env(SENTRY_ENVIRONMENT)%' | |||
integrations: | |||
- 'Sentry\Integration\IgnoreErrorsIntegration' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used IgnoreErrorsIntegration
before to filter out 4xx error (see further below in this file). We should add these exceptions again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
api/config/packages/sentry.yaml
Outdated
integrations: | ||
- 'Sentry\Integration\IgnoreErrorsIntegration' | ||
ignore_exceptions: | ||
- 'Symfony\Component\ErrorHandler\Error\FatalError' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to understand, why these should be ignored. To me it doesn't seem like an error that should be ignored. But there might be a good reason for it (maybe related to getsentry/sentry-symfony#63?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the changelog:
The IgnoreErrorsIntegration integration was removed. Use the ignore_exceptions option instead.
Previously, both Symfony\Component\ErrorHandler\Error\FatalError and
Symfony\Component\Debug\Exception\FatalErrorException were ignored by default.
To continue ignoring these exceptions, make the following changes to the config file:
https://github.com/getsentry/sentry-symfony/blob/master/UPGRADE-5.0.md
I am just keeping it the way it was. We can change it in another PR.
9509819
to
a2aacb5
Compare
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
a2aacb5
to
2b4260b
Compare
See https://github.com/getsentry/sentry-symfony/blob/HEAD/CHANGELOG.md#breaking-change Preserve ignored exceptions from before.
2b4260b
to
f5ebc07
Compare
This PR contains the following updates:
4.14.0
->5.0.0
Release Notes
getsentry/sentry-symfony (sentry/sentry-symfony)
v5.0.0
Compare Source
The Sentry SDK team is thrilled to announce the immediate availability of Sentry Symfony SDK v5.0.0.
Breaking Change
Please refer to the UPGRADE-5.0.md guide for a complete list of breaking changes.
This version adds support for the underlying Sentry PHP SDK v4.0.
Please refer to the PHP SDK sentry-php/UPGRADE-4.0.md guide for a complete list of breaking changes.
This version exclusively uses the envelope endpoint to send event data to Sentry.
If you are using sentry.io, no action is needed.
If you are using an on-premise/self-hosted installation of Sentry, the minimum requirement is now version
>= v20.6.0
.You need to have
ext-curl
installed to use the SDK.The
IgnoreErrorsIntegration
integration was removed. Use theignore_exceptions
option instead.Previously, both
Symfony\Component\ErrorHandler\Error\FatalError
andSymfony\Component\Debug\Exception\FatalErrorException
were ignored by default.To continue ignoring these exceptions, make the following changes to the config file:
This option performs an
is_a
check now, so you can also ignore more generic exceptions.Features
Add support for Sentry Developer Metrics (#1619)
Metrics are automatically sent to Sentry at the end of a request, hooking into Symfony's
kernel.terminate
event.Add new fluent APIs (#1601)
Simplify the breadcrumb API (#1603)
New default cURL HTTP client (#1589)
The SDK now ships with its own HTTP client based on cURL. A few new options were added.
To use a different client, you may use the
http_client
option.To use a different transport, you may use the
transport
option. A custom transport must implement theTransportInterface
.If you use the
transport
option, thehttp_client
option has no effect.Misc
php-http/message-factory
was removed.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.