Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: link to picasso #5133

Merged
merged 1 commit into from
May 7, 2024
Merged

dashboard: link to picasso #5133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions frontend/src/views/camp/Dashboard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,13 @@
class="mx-4 mt-6 mb-3"
style="border-collapse: collapse"
>
<caption class="font-weight-bold text-left">
{{
periods[uri].description
}}
<caption class="text-left">
<router-link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to focus this link with the keyboard (by tabbing), why is that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reproduce your problem

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it only happens on Firefox for me... Let's leave it for now

:to="periodRoute(periods[uri])"
class="text-decoration-none text-decoration-hover-underline black--text font-weight-bold"
>
{{ periods[uri].description }}
</router-link>
</caption>
<thead :key="uri + '_head'">
<tr class="d-sr-only">
Expand Down Expand Up @@ -124,6 +127,7 @@
</template>

<script>
import { periodRoute } from '@/router.js'
import ContentCard from '@/components/layout/ContentCard.vue'
import ActivityRow from '@/components/dashboard/ActivityRow.vue'
import { keyBy, groupBy, mapValues } from 'lodash'
Expand Down Expand Up @@ -264,6 +268,7 @@ export default {
})
},
methods: {
periodRoute,
persistRouterState() {
const query = transformValuesToHalId(this.filter)
if (filterAndQueryAreEqual(query, this.$route.query)) return
Expand Down Expand Up @@ -308,4 +313,8 @@ export default {
.day-header__row + tr > :is(th, td) {
border-top: 0;
}

.text-decoration-hover-underline:hover {
text-decoration: underline !important;
}
</style>
Loading