-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace hard coded api urls with templated links #5168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much.
Tested it locally, all dialoges still work and the href does not lead to an additonal request.
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this make sense to move these individual mounted definitions to the DialogBase
and provide the key, as the mounted call is identical?
This PR exactly fulfills the issue #977 |
Core Decision: Can be refactored later
fixes #977
successfully tested by verifying that all
mounted()
functions are called at least once and checking that the api calls still work by doing the corresponding action in the ui