Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use DOCKER_HUB_USERNAME instead of default ecamp for varnish image #5243

Merged
merged 1 commit into from
May 27, 2024

Conversation

usu
Copy link
Member

@usu usu commented May 26, 2024

I enabled API_CACHE_ENABLED on Github dev environment and on feature-branch environment.

Varnish didn't deploy properly, though. Reason was, that it looked for the image at docker.io/ecamp/ecamp3-varnish, however we're publishing the images at docker.io/ecamp3travis/ecamp3-varnish.

Does anyone remember, whether there was a specific reason why we switched from ecamp to ecamp3travis. We last published on ecamp in March 2023. ecamp is marked as a "community organization", while ecamp3travis seems to be a normal "community user".

@BacLuc
Copy link
Contributor

BacLuc commented May 26, 2024

I enabled API_CACHE_ENABLED on Github dev environment and on feature-branch environment.

Varnish didn't deploy properly, though. Reason was, that it looked for the image at docker.io/ecamp/ecamp3-varnish, however we're publishing the images at docker.io/ecamp3travis/ecamp3-varnish.

Does anyone remember, whether there was a specific reason why we switched from ecamp to ecamp3travis. We last published on ecamp in March 2023. ecamp is marked as a "community organization", while ecamp3travis seems to be a normal "community user".

as i recall, ecamp3travis is our DOCKER_HUB_USERNAME.
I never had access to the ecamp organisation on docker hub.
And we discussed it lately i think, and there were some restrictions about the size of the organisation.

@BacLuc
Copy link
Contributor

BacLuc commented May 26, 2024

It may be that after this commit: 6408263#diff-752f91fa9cecb6e8ac18316542fe6b6c0ab1b3899119e6252769d79bd30ec292R60

I (or someone else) changed DOCKER_HUB_USERNAME

@usu usu added this pull request to the merge queue May 27, 2024
Merged via the queue into ecamp:devel with commit 50c2a97 May 27, 2024
32 checks passed
@BacLuc BacLuc mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants