chore(api): remove ValidateDeleteRequestsListener #5275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes in OpenApi doc is probably related to api-platform/core#6360 |
BacLuc
reviewed
Jun 1, 2024
.../Api/SnapshotTests/__snapshots__/ResponseSnapshotTest__testOpenApiSpecMatchesSnapshot__1.yml
Show resolved
Hide resolved
.../Api/SnapshotTests/__snapshots__/ResponseSnapshotTest__testOpenApiSpecMatchesSnapshot__1.yml
Show resolved
Hide resolved
BacLuc
approved these changes
Jun 1, 2024
pmattmann
approved these changes
Jun 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5095
In the meantime, api platform supports validation for delete operation. Hence we can remove our own listener and enable validation via api-platform configuration.
Commit 1: ea8c46e
Removes our own listener
Failing tests proof that we have proper test for each endpoint which requires delete validation:
https://github.com/ecamp/ecamp3/actions/runs/9329296485/job/25681554883?pr=5275
Commit 2: 009ae7b
Enables delete validation for relevant endpoints