Add custom color campcollaboration

[manuelmeister]

Followup PR after #5174

[github-actions]

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

[usu]

Cool 🚀

[manuelmeister]

Core Meeting Decision

Implement as request by @usu

[usu]

Why was this removed? Is was not used?

[manuelmeister]

It was fully dead code. Unused, and not even tested.

[carlobeltrame]

Does one of these tests check for combining emojis? Such as skin color combiners etc.. I'm not an expert on this, so I don't know whether one of your tests already accounts for that.

[manuelmeister]

This is already one that is made out of 3 combined emojis.

The Man Mechanic: Light Skin Tone emoji is a ZWJ sequence combining 👨 Man, 🏻 Light Skin Tone, Zero Width Joiner and 🔧 Wrench.
– Emojipedia

[manuelmeister]

That's also the reason, that I've included some basic smileys below that should be each counted as one.

[carlobeltrame]

Wow, I learned something today.
In https://stackoverflow.com/a/72727900 it says that extended pictographic does not match a lone snowflake emoji, is that really the case? Should we use (\p{Emoji}\uFE0F|\p{Emoji_Presentation}) as that post suggests? Or is that covered in your additional logic with the length?

[manuelmeister]

Yes it is covered.

[carlobeltrame]

Looks great, thanks! As a future extension, I would like to be able to always change the color and abbreviation of my own camp collaboration, even if I'm only a guest. Would you agree?

[manuelmeister]

@carlobeltrame It somehow doesn't work with clientprint 😢 I didn't test it with a composed emoji until now. With "normal" emojis it works.

[manuelmeister]

@carlobeltrame I think we may rather add a color and abbreviation on the user, instead of user editable camp collaborators.

[carlobeltrame]

@carlobeltrame It somehow doesn't work with clientprint 😢 I didn't test it with a composed emoji until now. With "normal" emojis it works.

I see, but it looks like composed emoji are a general problem in client print. No reason to delay merging this feature in my opinion.

[manuelmeister]

@carlobeltrame indeed, emojis are very slow with clientprint 😢. It doesn't break, but initially it needs to load all emojis, and this is probably taking a while.

[carlobeltrame]

@carlobeltrame I think we may rather add a color and abbreviation on the user, instead of user editable camp collaborators.

That would work as well (though not as flexible). But if that's the ultimate goal, why didn't you implement that in the first place?

[carlobeltrame]

@carlobeltrame indeed, emojis are very slow with clientprint 😢. It doesn't break, but initially it needs to load all emojis, and this is probably taking a while.

If the loading time is the biggest problem, we could preload the emojis as soon as you navigate to a page with a print button. But also, currently, the combined emoji are rendered split up into their components. I think that is actually an intended fallback in the unicode standard, so it's okay but just not optimal.

[manuelmeister]

That would work as well (though not as flexible). But if that's the ultimate goal, why didn't you implement that in the first place?

Because it serves another purpose. I wanted a way to distinguish different users in a camp.

The user color/abbreviation would just be an override between generated and campcollaboration color/abbreviation, and be a better fallback.