Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use image in docker compose again to run e2e tests #5414

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Jun 21, 2024

@BacLuc BacLuc requested a review from a team July 9, 2024 19:34

- run: docker compose --profile e2e run --rm e2e --browser ${{ matrix.browser }}

- run: sudo chown -R $USER e2e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else github actions cannot upload the artifacts because they belong to the wrong user.
(github actions runs by default with user 1001 i think)

@usu usu added this pull request to the merge queue Jul 12, 2024
Merged via the queue into ecamp:devel with commit 2eff377 Jul 12, 2024
32 checks passed
This was referenced Aug 6, 2024
@BacLuc BacLuc deleted the e2e-use-docker-image branch August 28, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants