Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long links in richtext #5448

Closed

Conversation

carlobeltrame
Copy link
Member

Fixes #5446

@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Jun 28, 2024
Copy link

github-actions bot commented Jun 28, 2024

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest overflow-wrap: break-word instead. We don't want to break it unless we really have to.

@carlobeltrame carlobeltrame dismissed manuelmeister’s stale review June 28, 2024 11:16

I tried that, didn't suffice to resolve the problem.

@manuelmeister
Copy link
Member

Where did you have problems with this solution? Can you post the example?

@carlobeltrame
Copy link
Member Author

Where did you have problems with this solution? Can you post the example?

I'm running locally to test out the effects of your proposal. I won't push this to the feature branch deployment, you will have to test it yourself. How to reproduce:

In frontend/src/components/form/tiptap/TiptapEditor.vue:

div.editor:deep(div.ProseMirror) {
  overflow-wrap: break-word;
}

Displays like this in my Firefox on Linux:
Screenshot 2024-06-28 at 22-42-02 eCamp v3

The editor still grows uncontrollably, pushes other elements (e.g. the responsible column in the storyboard) out of the screen.

If I use the text cursor to go to the end of the link, it looks quite broken still, and the broken state even stays when I then nagivate the text cursor to the beginning of the rich text input:
Screenshot 2024-06-28 at 22-45-07 eCamp v3

@manuelmeister
Copy link
Member

@carlobeltrame I tried to debug this and found some other cases. I think I'd rather go with the standard property overflow-wrap. I've implemented the necessary changes in #5455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken UI with long links in Storyboard
2 participants