Storyboard.vue: remove css with no applications #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The css violates vue-scoped-css/require-v-deep-argument which will be more strictly enforced by vue3. I changed all the values to 10'000, and it had no effect. Because there was no explanation why this is here in the commit message, in the PR or in the comments, i delete this css. Was introduced in: PR: ecamp#3224 Commit: 9060a33
BacLuc
force-pushed
the
story-board-remove-deep-css
branch
from
48bb435
to
3e43a7b
Compare
manuelmeister
approved these changes
Jul 7, 2024
carlobeltrame
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The css violates vue-scoped-css/require-v-deep-argument which will be more strictly enforced by vue3.
I changed all the values to 10'000, and it had no effect. Because there was no explanation why this is here
in the commit message, in the PR or in the comments, i delete this css.
Was introduced in:
PR:
Commit: 9060a33