New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api): voters deny access when camp is null #6010

Merged

pmattmann merged 1 commit into ecamp:devel from usu:chore/voter-camp-null

Sep 27, 2024

Member

usu commented Sep 27, 2024

Refactors voters to deny access, if camp is null

Semantically more correct. is_granted("CAMP_MEMBER", object) returns false, if object has no camp and hence user cannot be a camp member
More robust implementation for entities where camp is optional (like Checklist)
For write operations where security should specifically be passed because a missing camp would trigger a validation error, this has now to be enabled explicitly for the properties which have such a validation


          voters deny access when camp is null

e525555

usu requested review from a team and pmattmann

September 27, 2024 20:00

pmattmann reviewed

View reviewed changes

Member

pmattmann left a comment

Didn't we say that we would add a comment each time?

pmattmann approved these changes

View reviewed changes

BacLuc approved these changes

View reviewed changes

pmattmann added this pull request to the merge queue

Merged via the queue into ecamp:devel with commit c3ab369

34 checks passed

usu mentioned this pull request

Checklist Prototypes #5930

Merged

6 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet