-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist-Overview with Activities #6026
base: devel
Are you sure you want to change the base?
Checklist-Overview with Activities #6026
Conversation
✅ Feature branch deployment ready!
|
3138910
to
5a558b8
Compare
dd3615b
to
ef01370
Compare
"href": "escaped_value" | ||
}, | ||
"checklistNodes": [], | ||
"children": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hier könnte man dann mal noch optimieren, dass wir die listen url herausgeben. (mit filter oder subresource)
<tr> | ||
<td colspan="2" style="text-wrap: wrap; line-height: 36px; padding-left: 6px"> | ||
{{ getPositionNumber(checklistItem) }}) | ||
{{ checklistItem.text }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hier könnte man es ähnlich machen wie beim print, dass die der text bis zum textanfang wrapped
: { backgroundColor: '#DDD' } | ||
}, | ||
getTotalNumberOfItemsAbove(checklistItem) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have the feeling, parts of this can be implemented with computed methods (which update when the dependencies update)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look & feel looks good to me. Reduction of number of network requests would be nice.
Noch nicht gelöst - aber für diesen PR nicht mehr relevant. Checklist-Übersicht-Anzeige ist jetzt schnell (nur 4 API-Aufrufe).
|
7eff682
to
27cca36
Compare
27cca36
to
2698965
Compare
Shows all Checklists with all ChecklistItems - and for each ChecklistItem all matching Activities.