Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklist-Overview with Activities #6026

Open
wants to merge 10 commits into
base: devel
Choose a base branch
from

Conversation

pmattmann
Copy link
Member

@pmattmann pmattmann commented Sep 28, 2024

Shows all Checklists with all ChecklistItems - and for each ChecklistItem all matching Activities.

@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label Sep 28, 2024
Copy link

github-actions bot commented Sep 28, 2024

Feature branch deployment ready!

Name Link
😎 Deployment https://pr6026.ecamp3.ch/
🔑 Login test@example.com / test
🕒 Last deployed at Thu Oct 03 2024 20:58:53 GMT+0200
🔨 Latest commit 8c7838f48d6aebf5cc565bb2a3a7476631b90853
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/11167961213/job/31045475427
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

@pmattmann pmattmann force-pushed the feature/checklist-overview-draft branch from 3138910 to 5a558b8 Compare September 28, 2024 18:06
@pmattmann pmattmann changed the title DRAFT - Checklist-Overview with Activities Checklist-Overview with Activities Sep 29, 2024
@pmattmann pmattmann marked this pull request as ready for review September 29, 2024 09:53
"href": "escaped_value"
},
"checklistNodes": [],
"children": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier könnte man dann mal noch optimieren, dass wir die listen url herausgeben. (mit filter oder subresource)

<tr>
<td colspan="2" style="text-wrap: wrap; line-height: 36px; padding-left: 6px">
{{ getPositionNumber(checklistItem) }})
{{ checklistItem.text }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier könnte man es ähnlich machen wie beim print, dass die der text bis zum textanfang wrapped

frontend/src/components/checklist/ChecklistItemTree.vue Outdated Show resolved Hide resolved
: { backgroundColor: '#DDD' }
},
getTotalNumberOfItemsAbove(checklistItem) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have the feeling, parts of this can be implemented with computed methods (which update when the dependencies update)

frontend/src/components/checklist/ChecklistItemTree.vue Outdated Show resolved Hide resolved
frontend/src/views/camp/Checklist.vue Outdated Show resolved Hide resolved
frontend/src/views/camp/Checklist.vue Outdated Show resolved Hide resolved
Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look & feel looks good to me. Reduction of number of network requests would be nice.

@pmattmann
Copy link
Member Author

pmattmann commented Oct 2, 2024

Noch nicht gelöst - aber für diesen PR nicht mehr relevant.
Ich habe einen eleganteren Weg gefunden.

Checklist-Übersicht-Anzeige ist jetzt schnell (nur 4 API-Aufrufe).

@ecamp/core

Ich stehe hier an.
Ich versuche alle ContentNodes auf einmal zu laden.

const contentNodes = this.checklistContentType._meta.load.then((items) => {
return api.contentNodes({
contentType: items.items[0]._meta.self,
camp: this.camp._meta.self,
})
})
await Promise.all([
this.camp.categories()._meta.load,
this.camp.activities().$reload(),
this.camp.checklists().$reload(),
contentNodes,
])

Lokal funktioniert das. Beim PR-Deployment jedoch nicht mehr.
Dort wird die Url falsch bestimmt /api/api/:
https://pr6026.ecamp3.ch/api/api/content_nodes?camp=%2Fcamps%2F5d28f99890bc&contentType=%2Fcontent_types%2Fa4211c11211c

Ich finde jedoch die Ursache dafür nicht.

Irgend eine Idee?

@pmattmann pmattmann deployed to feature-branch October 3, 2024 18:58 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants