Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit and delete checklists #6046

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

simfeld
Copy link
Contributor

@simfeld simfeld commented Sep 29, 2024

No description provided.

@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@pmattmann pmattmann requested a review from a team October 12, 2024 09:03
@usu
Copy link
Member

usu commented Oct 17, 2024

It would be nice if we find a way to mitigate the problem of the 404 errors and the staggered vanishing of the individual items. While it does the job currently, the UX is not very nice.

@usu
Copy link
Member

usu commented Oct 17, 2024

It would be nice if we find a way to mitigate the problem of the 404 errors and the staggered vanishing of the individual items. While it does the job currently, the UX is not very nice.

I tried to improve slightly with 54f8ae2

The errors are still in the console (they are coming from hal-json-vuex trying to reload the entities, not 100% sure why). But at least the frontend UX is a bit improved, not showing the item-by-item removal. @simfeld: What do you think?

@BacLuc
Copy link
Contributor

BacLuc commented Oct 17, 2024

Core Meeting Decision

  • it is ok that we have a delete button on the overview for now. But we should solve the problem of deleting the entities we are displaying right now soon, and then move the delete button back.

@simfeld
Copy link
Contributor Author

simfeld commented Oct 17, 2024

It would be nice if we find a way to mitigate the problem of the 404 errors and the staggered vanishing of the individual items. While it does the job currently, the UX is not very nice.

I tried to improve slightly with 54f8ae2

The errors are still in the console (they are coming from hal-json-vuex trying to reload the entities, not 100% sure why). But at least the frontend UX is a bit improved, not showing the item-by-item removal. @simfeld: What do you think?

@usu certainly much better, thank you. The side effect though is that in the error case (when the checklist is still used in activities) the checklist items vanish and reappear. That would be acceptable for me as a first pass.

@pmattmann pmattmann added this pull request to the merge queue Oct 19, 2024
Merged via the queue into ecamp:devel with commit d78b8ec Oct 19, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants