Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: error message improvement #259

Merged
merged 3 commits into from
Jan 25, 2022
Merged

chore: error message improvement #259

merged 3 commits into from
Jan 25, 2022

Conversation

usu
Copy link
Member

@usu usu commented Jan 22, 2022 •
edited
Loading

Contributes to #54

Improves the error message if a primitive property or a non-existing property is used like a relation.

Previously this threw something like

t2 is not a function

carlobeltrame
carlobeltrame approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How about a test? Should be pretty easy to write one, no?

@usu usu closed this Jan 23, 2022
@usu usu reopened this Jan 23, 2022
@usu
Copy link
Member Author

usu commented Jan 23, 2022

LGTM. How about a test? Should be pretty easy to write one, no?

Done d4e9cbd

@usu usu mentioned this pull request Jan 23, 2022
Open
4 tasks
@carlobeltrame
Copy link
Member

Thanks! Will do a release after we merge #260, okay?

@carlobeltrame carlobeltrame merged commit 515e3a7 into ecamp:next Jan 25, 2022
@usu
Copy link
Member Author

usu commented Jan 30, 2022

Thanks! Will do a release after we merge #260, okay?

Yes, good for me. Anyway nothing urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usu @carlobeltrame