(mini.colors) Fix convert() to have proper Oklab space detection.

echasnovski · Sep 25, 2023 · ec8cb73 · ec8cb73
1 parent 5947170
commit ec8cb73
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lua/mini/colors.lua b/lua/mini/colors.lua
@@ -2047,7 +2047,7 @@ H.infer_color_space = function(x)
   local is_num = H.is_number
   if is_num(x.l) then
     if is_num(x.c) then return 'oklch' end
-    if is_num(x.a) and is_num(x.a) then return 'oklab' end
+    if is_num(x.a) and is_num(x.b) then return 'oklab' end
     if is_num(x.s) then return 'okhsl' end
   end
 

diff --git a/tests/test_colors.lua b/tests/test_colors.lua
@@ -2041,6 +2041,7 @@ T['convert()']['validates arguments'] = function()
   expect.error(function() convert('aaaaaa', 'rgb') end, 'Can not infer color space of "aaaaaa"')
   expect.error(function() convert('##aaaaaa', 'rgb') end, 'Can not infer')
   expect.error(function() convert({}, 'rgb') end, 'Can not infer color space of {}')
+  expect.error(function() convert({ l = 50, a = 1 }, 'rgb') end, 'Can not infer color space of')
 
   -- - `nil` is allowed as input
   eq(child.lua_get([[MiniColors.convert(nil, 'hex')]]), vim.NIL)