[mini.files] cursorline is visible in file preview

[tvsfx]

Contributing guidelines

• I have read CONTRIBUTING.md
• I have read CODE_OF_CONDUCT.md
• I have updated 'mini.nvim' to latest version

Module(s)

mini.files

Description

When setting

vim.opt.cursorline = true
vim.opt.cursorlineopt = "line" -- Or "both"
require("mini.files").setup({ windows = { preview = true } })

The file preview will have the cursorline set.
I would turn the cursorline off myself in the MiniFilesWindowOpen handler, but there seems to be no way currently to differentiate between a preview of a file vs. a (preview of a ) directory in mini.files (bar requesting more state from mini.files and/or traversing the filesystem ourselves)

Neovim version

v0.10.2

Steps to reproduce

1. Use config options above
2. Open mini.files and navigate to any file so that the preview is shown
3. The preview will have its cursorline set

Expected behavior

Files do not have the cursorline set, since there is no way to edit them. For buffer previews this is different, since the line is where our cursor will land.

Actual behavior

Cursor line is set.

[echasnovski]

Thanks for the issue!

Haven't really noticed this myself, but I guess it indeed makes sense to not show cursorline in file previews. I'll take a look.

[echasnovski]

This should now be resolved on latest main branch. Thanks again for noticing this!

[tvsfx]

Just tested, and it works intermittently for me now (sometimes there's a cursorline, sometimes there's not). Specifically, there's a cursorline for the first preview in a newly opened folder, and after that, no more cursorline is shown.
I think the following code might be the issue:

mini.nvim/lua/mini/files.lua

Lines 2480 to 2481 in d084df4

	-- Make sure that 'cursorline' is not overridden by `config.style`
	vim.wo[win_id].cursorline = true

[echasnovski]

Yeah, my bad, didn't interactively test when file is immediately previewed after opening explorer. Should be fixed now.

I think the following code might be the issue:

Only partially, but yes: 'cursorline' was set initially, but did not get unset later due to a big if statement (which should have been a more direct vim.wo[win_id].cursorline = <boolean: path is for directory>.

[tvsfx]

Now it works like a charm, thanks :)