Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basics: enhance window resize logic #539

Closed
wants to merge 1 commit into from
Closed

Basics: enhance window resize logic #539

wants to merge 1 commit into from

Conversation

wroyca
Copy link
Contributor

@wroyca wroyca commented Oct 24, 2023

Window resizing was a bit confusing, with left sometimes behaving like right and right sometimes behaving like left. This was not in line with user expectations. This PR enhance the logic behind, ensuring that left remains left and right remains right, similar to how it works for "nN" and "Nn" and/or "gj" and "gk".

Screencast.from.2023-10-24.09-02-29.webm

The best way to do it is to receive a positive feedback from maintainer on your initiative in one of the GitHub issues (existing one or created by you otherwise).

Sorry about that, I read this after the fact ^

Window resizing was a bit confusing, with left sometimes behaving like right and right sometimes behaving like left. This was not in line with user expectations. 

Here we enhance the logic behind, ensuring that left remains left and right remains right, similar to how it works for "nN" and "Nn."
@wroyca wroyca marked this pull request as draft October 24, 2023 13:12
@wroyca
Copy link
Contributor Author

wroyca commented Oct 24, 2023

I will need some free time available to figure out the whole testing machinery and update it accordingly. If anyone wants to beat me to it, feel free to go ahead!

@echasnovski
Copy link
Owner

Thanks for taking time to make this!

The best way to do it is to receive a positive feedback from maintainer on your initiative in one of the GitHub issues (existing one or created by you otherwise).

Sorry about that, I read this after the fact ^

Yeah, that is somewhat of a crucial part here. I did notice this behavior when adding these keymaps and intentionally left them as is. The point of 'mini.basics' mappings is to be easy to understand and copy-pasteable (with some exceptions).

Default commands work as they are described: they increase/decrease width/height. This is usually the same as "move edge right/left/up/down" but not for right/bottom windows (which move left/top edge in opposite direction). This needs some getting used to, but works as intended.

Sorry, but I am closing this one as not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants