Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the Map from requesting location more than once. #309

Merged
merged 2 commits into from
May 17, 2024
Merged

Prevent the Map from requesting location more than once. #309

merged 2 commits into from
May 17, 2024

Conversation

alejandrocalles
Copy link
Contributor

@alejandrocalles alejandrocalles commented May 17, 2024 •
edited
Loading

Closes #316.

@alejandrocalles alejandrocalles self-assigned this May 17, 2024
@alejandrocalles alejandrocalles added the bug Something isn't working label May 17, 2024
@violoncelloCH violoncelloCH self-requested a review May 17, 2024 06:15
@alejandrocalles alejandrocalles force-pushed the fix/location-permissions branch 2 times, most recently from 391db6c to d3e5a19 Compare May 17, 2024 14:31
@alejandrocalles alejandrocalles added this to the Milestone 3 milestone May 17, 2024
@alejandrocalles
Copy link
Contributor Author

Moving the handling of location permissions to the AppNavigationHost also sets the ground for #318.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

violoncelloCH
violoncelloCH approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@violoncelloCH violoncelloCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much for working on this important usability improvement!

Just a small general remark on coding style: to make code as easy to read and understand as possible, it generally helps to avoid single-letter variable names, but rather use something expressive. It really helps if the chosen names for variables, functions and classes clearly express what they do/are.
But well done :)

@alejandrocalles
Copy link
Contributor Author

That's fair, I'll take care of this during the next sprint, as my tasks are closely related to the permissions. Thanks for your review :)

@alejandrocalles alejandrocalles merged commit 2c07ef2 into main May 17, 2024
2 checks passed
@alejandrocalles alejandrocalles deleted the fix/location-permissions branch May 17, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@violoncelloCH violoncelloCH violoncelloCH approved these changes

Assignees

@alejandrocalles alejandrocalles

Labels
bug Something isn't working
Projects
echo
Status: Done in sprint 8
Milestone
Milestone 3
Development

Successfully merging this pull request may close these issues.

Location permissions should only be requested once per session.
2 participants
@alejandrocalles @violoncelloCH