user profile picture in the create profile screen and the hamburger menu #358

unglazedstamp · 2024-05-27T21:10:45Z

need #346 merged first

ntissieres · 2024-05-30T07:56:29Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

-                    singleLine = true,
-                    isError = lastName.isBlank()
-                )
+                        Spacer(modifier = modifier.height(5.dp))


The height of the spacer can be set into a val at the beginning of the file, while it is use multiple times

ntissieres · 2024-05-30T08:04:25Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+            }
+        }
+    val pictureDisplaySize = 100.dp
+    Column(modifier = Modifier.padding(start = 5.dp)) {


Again, try to avoid magic values in padding

ntissieres · 2024-05-30T08:05:10Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+                        )
+                    },
+                painter =
+                    if (picture != null) {


Nice idea to use the echo logo if no profile picture !

ntissieres · 2024-05-30T08:05:41Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+                        painterResource(R.drawable.echologoround)
+                    },
+                contentDescription = "",
+                alpha = 0.5f


magic value

ntissieres · 2024-05-30T08:06:08Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+            )
+        }
+        IconButton(
+            modifier = Modifier.align(Alignment.End).offset(x = 10.dp, y = (-10).dp),


magic values

ntissieres · 2024-05-30T08:11:11Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+ * @param picture: the picture to center
+ * @param onConfirm: callback called when the picture is centered
+ * @param onCancel: callback when the action is canceled
+ */


What a determination to implement that haha, nice feature !

Yes I really wanted to do something similar to what most social media app do with the profile picture, it's not as good as these apps but it's clearly usable.

ntissieres · 2024-05-30T08:12:57Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+                style = Stroke(strokeSize)
+            )
+        }
+        Card(modifier = Modifier.align(Alignment.TopCenter).offset(y = 20.dp)) {


magic value

ntissieres · 2024-05-30T08:13:12Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+        }
+        Card(modifier = Modifier.align(Alignment.TopCenter).offset(y = 20.dp)) {
+            Text(
+                modifier = Modifier.padding(5.dp),


magic value

ntissieres · 2024-05-30T08:13:33Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+        }
+        Row(
+            modifier =
+                Modifier.align(Alignment.BottomEnd).padding(horizontal = 0.dp, vertical = 15.dp)


magic values

ntissieres

Truly impressive code ! You realy manage to make the feature of adding profiles pictures very handy for the user, nice work ! Still, there is some minor changes required :

A lot of magic values to put into val in order to make the maintenance easier in the case we want to change things
The profile picture in the hamburger menu is a bit overlapping the switch dark/light mode. It could be good to replace the "close hamburger menu" button (the cross) which is not necessary anymore with the light/dark mode button.
The center picture feature is good, but instead of using the circle to indicate the center of the picture, it would be better to enlarge it to show instead what part of the picture will be selected

Otherwise, I tried to change my profile picture and it works great ;)

srsingh04

Nice code, thank you for working on the feature. Some minor changes to be done and then it should be good to go.
Overall good work.

srsingh04 · 2024-05-30T08:47:39Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+        rememberLauncherForActivityResult(ActivityResultContracts.PickVisualMedia()) { uri ->
+            if (uri == null) {
+                Log.w("photo picker", "photo not found")
+            } else {


Instead of a nested if else loop, to break down, after the first if: you could break it down by just putting a return@rememberLauncherForActivityResult when uri or rawPicture are null. This coudl help get rid of the nested if else block, which could be better for the cognitive complexity. What do you think?

I believe that it's better for maintainability to have a clear if else statement, furthermore the else statement allow for smart casting which is good for code readability and safety.

srsingh04 · 2024-05-30T08:55:10Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+    var showPictureDialog by remember { mutableStateOf(false) }
+    val localContext = LocalContext.current
+    if (!isPhotoPickerAvailable(localContext)) {
+        Log.e("CreateProfile", "Photo picker not available")


Maybe you could add an empty return statement after the log if the photo picker is not available so that it doesn't go through the rest of the code and is more optimized? What do you think?

If the photo picker isn't available, android uses a fallback, so the feature is still relevant, however our application isn't supposed to be used on these old device and some error could arise (e.g. select a file which isn't a picture) so I log an error

srsingh04 · 2024-05-30T09:01:29Z

app/src/main/java/com/github/swent/echo/viewmodels/HomeScreenViewModel.kt

+                if (pictureByteArray != null) {
+                    BitmapFactory.decodeByteArray(pictureByteArray, 0, pictureByteArray.size)
+                } else {
+                    null


Is the else block necessary? The default value is set to null, so you could safely get rid of the else block.

srsingh04 · 2024-05-30T09:06:51Z

app/src/main/java/com/github/swent/echo/viewmodels/authentication/CreateProfileViewModel.kt

+                                pictureByteArray.size
+                            )
+                        } else {
+                            null


Similarly, the else block is not required here because the default value is null already.

srsingh04 · 2024-05-30T09:39:23Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+        return offs.x > -picture.width * sca / 2f + circleRadius &&
+            offs.y > -picture.height * sca / 2f + circleRadius &&
+            offs.x < picture.width * sca / 2f - circleRadius &&
+            offs.y < picture.height * sca / 2f - circleRadius &&


you could modularize the return statement by defining each set of conditions as variables and then using them in the return statement. This would also allow someone in the future to easily edit the conditions without much hassle.

srsingh04 · 2024-05-30T09:41:26Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+                newScale
+            } else {
+                scale
+            }


Again, I think the else block can be safely deleted because the scale variable just keeps its value when the condition is not respected.

srsingh04 · 2024-05-30T09:41:44Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+            if (isTransformInside(newOffset, scale)) {
+                newOffset
+            } else {
+                offset


idem, else block can be safely deleted.

srsingh04 · 2024-05-30T09:49:07Z

app/src/test/java/com/github/swent/echo/compose/authentication/CreateProfileTest.kt

+        image.assertPositionInRootIsEqualTo(15.dp, 15.dp)
+    }
+
+    // this test needs to be run there because of the Bitmap class which require android


Knitpick: the comment is a bit confusing: what exactly do you mean by 'test needs to be run there'? run where? Maybe I am just confused for nothing here...

ok I will remove this comment

srsingh04

Great! Thank you for the nice feature. Ready to be merged from my side.

ntissieres · 2024-05-30T18:18:55Z

app/src/main/java/com/github/swent/echo/compose/authentication/CreateProfile.kt

+    onConfirm: (picture: Bitmap) -> Unit,
+    onCancel: () -> Unit
+) {
+    val circleRadius = min(picture.width, picture.height) * 3 / 8


I don't think it's a good idea to set the circle radius according the image size. I tried it with different image, and some mystical things happens if the image is not the same size as the screen. I think it would be preferable to use a fix size

The problem here is that if the picture is smaller than the fixed size then the app crashes

ntissieres

Thanks for the changes !!

…tory

sonarcloud · 2024-05-31T08:59:17Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
74.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

unglazedstamp self-assigned this May 28, 2024

unglazedstamp added this to the Milestone 4 milestone May 28, 2024

unglazedstamp linked an issue May 28, 2024 that may be closed by this pull request

Add image to user profile creation/edition screen #337

Closed

unglazedstamp force-pushed the feature/userprofile-picture-frontend branch 4 times, most recently from baff9ad to 79ec557 Compare May 29, 2024 20:08

unglazedstamp marked this pull request as ready for review May 29, 2024 20:16

unglazedstamp force-pushed the feature/userprofile-picture-frontend branch 2 times, most recently from 03dea5d to ad0f19a Compare May 29, 2024 22:18

ntissieres self-requested a review May 30, 2024 07:45

ntissieres reviewed May 30, 2024

View reviewed changes

srsingh04 self-requested a review May 30, 2024 08:19

ntissieres requested changes May 30, 2024

View reviewed changes

srsingh04 requested changes May 30, 2024

View reviewed changes

unglazedstamp requested review from srsingh04 and ntissieres May 30, 2024 17:39

unglazedstamp enabled auto-merge (rebase) May 30, 2024 17:39

srsingh04 previously approved these changes May 30, 2024

View reviewed changes

ntissieres reviewed May 30, 2024

View reviewed changes

unglazedstamp dismissed srsingh04’s stale review via 1591012 May 31, 2024 06:05

unglazedstamp force-pushed the feature/userprofile-picture-frontend branch from 1591012 to 6a540a7 Compare May 31, 2024 07:54

unglazedstamp force-pushed the feature/userprofile-picture-frontend branch 2 times, most recently from 8195b5d to b1bba06 Compare May 31, 2024 08:41

ntissieres self-requested a review May 31, 2024 08:41

ntissieres approved these changes May 31, 2024

View reviewed changes

yoan added 11 commits May 31, 2024 08:47

add profile picture getters and setters to the create profile viewmodel

b4255be

add profile picture to the create profile screen

266ac55

add profile picture to the hamburger menu

501e569

adapt tests

a0b8567

add tests for profile creation

d023744

adapt homescreen viewmodel and create profile viewmodel to the reposi…

727c1d9

…tory

add more tests

653b2a9

replace magic values with variables

c5fbdcc

improve code readability

6ba5c02

replace close button with theme toggle button

550b866

remove moving picture capabilities

b0a5444

unglazedstamp force-pushed the feature/userprofile-picture-frontend branch from b1bba06 to b0a5444 Compare May 31, 2024 08:47

unglazedstamp merged commit aac986d into main May 31, 2024
2 checks passed

unglazedstamp deleted the feature/userprofile-picture-frontend branch May 31, 2024 08:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

user profile picture in the create profile screen and the hamburger menu #358

user profile picture in the create profile screen and the hamburger menu #358

unglazedstamp commented May 27, 2024 •

edited

Loading

ntissieres May 30, 2024

ntissieres May 30, 2024

ntissieres May 30, 2024

ntissieres May 30, 2024

ntissieres May 30, 2024

ntissieres May 30, 2024

unglazedstamp May 30, 2024 •

edited

Loading

ntissieres May 30, 2024

ntissieres May 30, 2024

ntissieres May 30, 2024

ntissieres left a comment •

edited

Loading

srsingh04 left a comment

srsingh04 May 30, 2024

unglazedstamp May 30, 2024

srsingh04 May 30, 2024

unglazedstamp May 30, 2024

srsingh04 May 30, 2024

srsingh04 May 30, 2024

srsingh04 May 30, 2024

srsingh04 May 30, 2024

srsingh04 May 30, 2024

srsingh04 May 30, 2024

unglazedstamp May 30, 2024

srsingh04 left a comment

ntissieres May 30, 2024

unglazedstamp May 31, 2024

ntissieres left a comment

sonarcloud bot commented May 31, 2024

user profile picture in the create profile screen and the hamburger menu #358

user profile picture in the create profile screen and the hamburger menu #358

Conversation

unglazedstamp commented May 27, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

unglazedstamp May 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntissieres left a comment • edited Loading

Choose a reason for hiding this comment

srsingh04 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srsingh04 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ntissieres left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 31, 2024

Quality Gate passed

unglazedstamp commented May 27, 2024 •

edited

Loading

unglazedstamp May 30, 2024 •

edited

Loading

ntissieres left a comment •

edited

Loading