Provide feedback in UI about network issues and allow for retrying #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
violoncelloCH
force-pushed
the
imp/ui-handle-network-errors
branch
from
2fa2397
to
1aef1e2
Compare
violoncelloCH
force-pushed
the
imp/ui-handle-network-errors
branch
from
1aef1e2
to
d0fb474
Compare
violoncelloCH
force-pushed
the
imp/ui-handle-network-errors
branch
2 times, most recently
from
4e87b64
to
c7b8acf
Compare
unglazedstamp
requested changes
May 31, 2024
There was a problem hiding this comment.
Very good code. This improves a lot the user experience compared to before. Now even if for some reason the connection server fails while online, the user will know that it has failed and he will have the oportunity to retry. I found some improvements in the code.
app/src/main/java/com/github/swent/echo/viewmodels/association/AssociationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/swent/echo/viewmodels/association/AssociationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/swent/echo/viewmodels/myevents/MyEventsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/swent/echo/viewmodels/myevents/MyEventsViewModel.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
violoncelloCH
force-pushed
the
imp/ui-handle-network-errors
branch
from
8990afd
to
0ffb701
Compare
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
violoncelloCH
force-pushed
the
imp/ui-handle-network-errors
branch
from
0ffb701
to
2d70887
Compare
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
violoncelloCH
force-pushed
the
imp/ui-handle-network-errors
branch
from
2d70887
to
f2a8531
Compare
|
unglazedstamp
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #370
based on #361Edit: branch was merged and this one rebased