-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide feedback in UI about network issues and allow for retrying #371
Conversation
2fa2397
to
1aef1e2
Compare
1aef1e2
to
d0fb474
Compare
4e87b64
to
c7b8acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good code. This improves a lot the user experience compared to before. Now even if for some reason the connection server fails while online, the user will know that it has failed and he will have the oportunity to retry. I found some improvements in the code.
app/src/main/java/com/github/swent/echo/viewmodels/association/AssociationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/swent/echo/viewmodels/association/AssociationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/swent/echo/viewmodels/myevents/MyEventsViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/github/swent/echo/viewmodels/myevents/MyEventsViewModel.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
8990afd
to
0ffb701
Compare
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
0ffb701
to
2d70887
Compare
Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
2d70887
to
f2a8531
Compare
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this very valuable feature.
closes #370
based on #361Edit: branch was merged and this one rebased