-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GPS Service. #373
Add a GPS Service. #373
Conversation
61f1233
to
188f72c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for working on this! Really clean code and a nice structure with the interface, implementation and hilt module!
I just have a concern regarding the use o the proprietary google play library. Since we so far managed to avoid dependencies on any proprietary library, this makes the app require the presence of Googles proprietary services. It will not work on devices not having them installed like Huaweis more recent Smartphone, Amazon's Android devices, Windows new capability for running Android apps as well as privacy friendly Android variants coming without Google Services by design.
The solution for this would be to uses pure Android APIs for the location as detailed e.g. in this blog post: https://fobo66.dev/post/play-services-location-migration/#how-to-request-current-location-with-locationmanager
However given the approaching deadline, I'm not sure if it's reasonable to attempt this now. What do you think?
It's a good point, and I hadn't really thought about it.Unfortunately, I don't think it would be reasonable to make those changes in this PR. However, I do believe it would be better to stay away from proprietary libraries, so I would consider creating an issue in case this project is continued in the future :) |
a0d4fe0
to
114ff11
Compare
b3fcd64
to
3248bd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clean code! Good job, LGTM: ready to be merged.
1945dac
to
de0e38d
Compare
de0e38d
to
42967bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as already said, nice implementation! thanks for the massive work!
I'll create an issue as discussed for the dependency concern :)
Quality Gate passedIssues Measures |
Closes #318.