Feature/sort by distance #382
Conversation
alejandrocalles
force-pushed
the
feature/sort-by-distance
branch
2 times, most recently
from
ffcaa69
to
1b51684
Compare
alejandrocalles
force-pushed
the
feature/sort-by-distance
branch
from
1b51684
to
26ee0d4
Compare
|
User should be able to sort events by distance ascending or descending. By default, events are sorted by date, so the distance sort is applied on top, but this doesn't really matter as it is unlikely to have two events at the same coordinates. |
| @Provides | ||
| fun provideGPSService(application: Application): GPSService { | ||
| val context = application.applicationContext | ||
| return GPSServiceImpl(context) |
There was a problem hiding this comment.
Knitpick/Suggestion for next time: Maybe instead of defining context as a variable, use its declaration directly in the return statement since we only use it once?
| val fmt = { format: String, value: Double -> | ||
| String.format(Locale.getDefault(), format, value) | ||
| } | ||
| if (it < 1000) fmt("%.0fm", it) else fmt("%.1fkm", it / 1000.0) |
There was a problem hiding this comment.
Knitpick: good practise to not Magic values in the code: 1000.0 can be extracted into a variable?
| canModifyEvent = canModifyEvent, | ||
| distance = userLocation?.let { event.location.toLatLng().distanceTo(it) }, | ||
| ) | ||
| Spacer(modifier = Modifier.height(12.dp)) |
There was a problem hiding this comment.
Similarly for the height value, could be extracted into a variable to b e able to make modifications easily by someone else in the future
unglazedstamp
requested review from
unglazedstamp
and removed request for
unglazedstamp
|
Those are good points! I have addressed them. |
|
Sort events by distance.
Display distance to user in
EventListItem, but only on theHomeScreen.Closes #383 and #384.