Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding details #784

Merged
merged 13 commits into from
Dec 21, 2022
Merged

Fix finding details #784

merged 13 commits into from
Dec 21, 2022

Conversation

proditis
Copy link
Collaborator

@proditis proditis commented Dec 20, 2022

This PR does the following

  • only display IP on the target pages for private instances
  • dont display IP's on writeups, headshots and leaderboards
  • fix a bug with use of target alias (we changed the default to t)
  • on findings display
    • hostname if target is ondemand and powered down
    • target ip for ondemand powered up
    • instance ip for private instances currently up and viewed by the owning player
  • fixes a bug in versus pages titles

fixes #783

@proditis proditis merged commit 579eedc into echoCTF:master Dec 21, 2022
@proditis proditis deleted the fix-finding-details branch December 21, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] player findings dont show the correct IP
1 participant