feat: Make external links themeable with Chakra UI #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-jenn-or
reviewed
Nov 4, 2021
There was a problem hiding this comment.
I think there is overlap with this and the footer component PR #235 so we will have some collisions if both are merged.
kyleshevlin
approved these changes
Nov 4, 2021
tundera
force-pushed
the
themeable-links
branch
from
798b533
to
a47c20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External links are currently implemented with
<a>tags in JSX. Chakra UI has aLinkcomponent which has the same functionality asa, while also making the links themeable through variants defined in the default or a custom theme via Chakra's theming API. See this discussion for context and an example.Changes
Linkcomponent from Chakra UItarget="_blank"andrel="noopener noreferrer"attributes on external links with theisExternalprop on the substitutedLinkcomponents which provides the same functionalityScreenshots
Checklist