Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates and uses shared Footer component #235

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

kyleshevlin
Copy link
Contributor

I noticed an issue with a static year in the footer of the layouts. This PR fixes this, and creates a shared Footer.

Changes

  • Creates a shared Footer component
  • Dynamically sets the year for the copyright
  • Changes the text of the footer from i to em (though arguably this should be done with CSS as I don't think the content itself is semantically emphasized).

Checklist

  • Requires dependency update?
  • Generating a new app works

@kgajera kgajera linked an issue Oct 19, 2021 that may be closed by this pull request
Copy link
Contributor

@code-jenn-or code-jenn-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this refactor, one component to rule them all

@kgajera kgajera merged commit 61bfbcc into echobind:canary Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update footer component to create a dynamic copyright date
4 participants