Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Simplify env files. #313

Merged
merged 9 commits into from
Apr 13, 2023
Merged

chore: Simplify env files. #313

merged 9 commits into from
Apr 13, 2023

Conversation

cullylarson
Copy link
Contributor

@cullylarson cullylarson commented Apr 7, 2023 •
edited
Loading

Changes

  • fix: A few copyFile entries mistakenly target the wrong files.
  • chore: Remove .env.local. We shouldn't ever need .env.local because it will be applied at every stage (not usually intended).
  • chore: Don't override values in env.*.local unless needed.
  • chore: Don't set any values in .env. Use it as basically a template. The value in .env will be applied to every environment, which doesn't usually make sense.

Checklist

  • Requires dependency update?
  • Generating a new app works

@cullylarson cullylarson mentioned this pull request Apr 10, 2023
Merged
2 tasks
kgajera
kgajera approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@kgajera kgajera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I've missed something, we can remove APP_ENV after #312 is merged.

packages/create-bison-app/template/_.env.ejs Outdated Show resolved Hide resolved
packages/create-bison-app/template/_.env.development.ejs Outdated Show resolved Hide resolved
@cullylarson cullylarson merged commit 8400c9f into canary Apr 13, 2023
@cullylarson cullylarson deleted the cully/fix-copy-env-files branch April 13, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgajera kgajera kgajera approved these changes

@alexanderson1993 alexanderson1993 alexanderson1993 approved these changes

@cball cball Awaiting requested review from cball

@mthomps4 mthomps4 Awaiting requested review from mthomps4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cullylarson @kgajera @alexanderson1993