Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Default mount name should be undef so it gets filled in the module #23

Merged
merged 1 commit into from May 16, 2015
Merged

Default mount name should be undef so it gets filled in the module #23

merged 1 commit into from May 16, 2015

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2015

Otherwise it tries to mount the share by its title unless you have explicitly specified the path in the node manifest. And if you have, autogeneration of mount paths ("${nfs::client::nfs_v4_mount_root}/${share}") won't work.

@ghost
Copy link
Author

ghost commented May 16, 2015

Hmm, the build is failing and I'm struggling to find the reason. Is everything all right with Travis?

@dwerder
Copy link
Member

dwerder commented May 16, 2015

The travis CI is red, because of failures in coding conventions.

manifests/client/debian/service.pp - WARNING: ensure found on line but it's not the first attribute on line 15
manifests/client/redhat/service.pp - WARNING: selector inside resource block on line 12
manifests/client/redhat/service.pp - WARNING: selector inside resource block on line 18
manifests/client/redhat/service.pp - WARNING: selector inside resource block on line 28

@dwerder
Copy link
Member

dwerder commented May 16, 2015

But thats not a problem right now.

dwerder added a commit that referenced this pull request May 16, 2015
Default mount name should be undef so it gets filled in the module
@dwerder dwerder merged commit bcff41d into echocat:master May 16, 2015
@dwerder
Copy link
Member

dwerder commented May 16, 2015

I was wrong. It seems that travis has a problem with cloning stdlib for spec/fixtures. strange.

@ghost
Copy link
Author

ghost commented May 17, 2015

Yeah, I couldn't get to the bottom of it. Thanks for your quick reaction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant