Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV customization #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CSV customization #2

wants to merge 4 commits into from

Conversation

keichan34
Copy link

I've made a couple modifications to customize the CSV output in a Spree project that I've been working on.

  • Custom output encoding (Apps like Excel don't like UTF-8 😞 )
  • Default options to be passed to CSV
  • The option to make a proc generate the CSV file
  • Appropriate suggested filename for CSV download

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling dddd302 on keichan34:csv-customization into 0f39925 on ecl1pse:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 348b7f2 on keichan34:csv-customization into 0f39925 on ecl1pse:master.

@ecl1pse
Copy link
Owner

ecl1pse commented Aug 29, 2013

Thanks so much for the pull request.

Can you add any additional tests or do you not think any are needed?

@keichan34
Copy link
Author

I'll work on the test as soon as I can!

I think some unit tests on the decorators could be useful too

@ecl1pse
Copy link
Owner

ecl1pse commented Sep 4, 2013

Any updates?

@ecl1pse
Copy link
Owner

ecl1pse commented Sep 9, 2013

@keichan34 you around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keichan34 @coveralls @ecl1pse